Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source Paypal Transation: RESULTSET_TOO_LARGE validation #14804

Merged
merged 12 commits into from
Jul 19, 2022
Merged

🎉 Source Paypal Transation: RESULTSET_TOO_LARGE validation #14804

merged 12 commits into from
Jul 19, 2022

Conversation

lazebnyi
Copy link
Collaborator

What

#4404 - Paypal Transation stream should handle API error in case of 10000 records in request

How

Added to read_records RESULTSET_TOO_LARGE validation if error rises date slice divided to two.

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 18, 2022
@lazebnyi lazebnyi changed the title Source Paypal Transation: RESULTSET_TOO_LARGE validation 🎉 Source Paypal Transation: RESULTSET_TOO_LARGE validation Jul 18, 2022
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jul 18, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/2692698137
✅ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/2692698137
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_paypal_transaction/utils.py          8      0   100%
source_paypal_transaction/__init__.py       2      0   100%
source_paypal_transaction/source.py       237     69    71%
-----------------------------------------------------------
TOTAL                                     247     69    72%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 20 passed, 2 skipped in 18.52s ========================

@grubberr
Copy link
Contributor

@lazebnyi hm I run

gradlew blackFormat

and a lot of files changed
does it work for us different ?

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jul 19, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-paypal-transaction

🕑 Publishing the following connectors:
connectors/source-paypal-transaction
https://github.com/airbytehq/airbyte/actions/runs/2699826514


Connector Did it publish? Were definitions generated?
connectors/source-paypal-transaction ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@lazebnyi lazebnyi linked an issue Jul 19, 2022 that may be closed by this pull request
Paypal Transation stream should handle API error in case of 10000 records in request #4404
Closed
@lazebnyi lazebnyi marked this pull request as ready for review July 19, 2022 18:38
@lazebnyi lazebnyi merged commit 037d634 into master Jul 19, 2022
@lazebnyi lazebnyi deleted the lazebnyi/4404-paypal-transation-resultset-too-large-validation branch July 19, 2022 18:52
mfsiega-airbyte pushed a commit that referenced this pull request Jul 21, 2022
@lazebnyi @octavia-squidington-iii @mfsiega-airbyte
🎉 Source Paypal Transation: RESULTSET_TOO_LARGE validation (#14804)
823a826 
* Updated API version from v9 to v11

* Updated PR number

* Updated after review

* Added validation error

* Fixed to linter

* Updated PR number

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grubberr grubberr grubberr approved these changes

@arsenlosenko arsenlosenko arsenlosenko approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads connectors/source/paypal-transaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paypal Transation stream should handle API error in case of 10000 records in request
4 participants
@lazebnyi @grubberr @arsenlosenko @octavia-squidington-iii